Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't probe empty CD drives #90

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

smira
Copy link
Member

@smira smira commented Apr 5, 2024

Fixes #81

@smira
Copy link
Member Author

smira commented Apr 5, 2024

Testing with Talos, with boot CD present:

metadata:
    namespace: runtime
    type: DiscoveredVolumes.block.talos.dev
    id: sr0
    version: 1
    owner: block.DiscoveryController
    phase: running
    created: 2024-04-05T15:39:31Z
    updated: 2024-04-05T15:39:31Z
spec:
    type: disk
    devicePath: /sys/devices/pci0000:00/0000:00:1f.2/ata3/host2/target2:0:0/2:0:0:0/block/sr0
    size: 93255680
    sectorSize: 2048
    ioSize: 2048
    name: iso9660
    label: ISOIMAGE
    blockSize: 2048
    filesystemBlockSize: 2048
    probedSize: 93255680

When CD is not present, sr0 doesn't appear.

@smira
Copy link
Member Author

smira commented Apr 5, 2024

/m

@talos-bot talos-bot merged commit 21c66f8 into siderolabs:v2 Apr 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants