Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an equivalent of WaitWrapper for os.Process #5

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dsseng
Copy link
Member

@dsseng dsseng commented Oct 18, 2024

For using os.Process in Talos replacing exec.Cmd in some places we need to ba able to use reaper with it.

Signed-off-by: Dmitry Sharshakov [email protected]

Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be really good to have a test for the new function

pkg/cmd/proc/reaper/wait.go Outdated Show resolved Hide resolved
@dsseng dsseng force-pushed the reaper-process branch 3 times, most recently from c02bfec to fb93df5 Compare October 18, 2024 16:01
For using os.Process in Talos replacing exec.Cmd in some places we need to ba able to use reaper with it.

Signed-off-by: Dmitry Sharshakov <[email protected]>
@dsseng
Copy link
Member Author

dsseng commented Oct 18, 2024

/m

@talos-bot talos-bot merged commit 5662c7f into siderolabs:main Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants