fix: generation of SBC images #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is in siderolabs/talos#8076 Also bump the hash to flush the SBC cached images. Fixes siderolabs#65 Signed-off-by: Andrey Smirnov <[email protected]>
smira
commented
Dec 15, 2023
| @@ -233,7 +233,7 @@ func testDownloadFrontend(ctx context.Context, t *testing.T, baseURL string) { | |||
| t.Run("rpi image", func(t *testing.T) { | |||
| t.Parallel() | |||
|
|
|||
| downloadAssetAndMatchSize(ctx, t, baseURL, emptySchematicID, talosVersion, "metal-rpi_generic-arm64.raw.xz", "application/x-xz", 66574172) | |||
| downloadAssetAndMatchSize(ctx, t, baseURL, emptySchematicID, talosVersion, "metal-rpi_generic-arm64.raw.xz", "application/x-xz", 107183936) | |||
There was a problem hiding this comment.
the image getting correct size is the sign of the fix working :)
frezbo
reviewed
Dec 15, 2023
| // update the hash value to force rebuild assets once the bug is fixed | ||
| // | ||
| // 1. errata https://github.com/siderolabs/image-factory/issues/65 | ||
| if p.Board != "" { |
There was a problem hiding this comment.
oooohhh, I like this way of adding tests for errara
frezbo
approved these changes
Dec 15, 2023
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is in siderolabs/talos#8076
Also bump the hash to flush the SBC cached images.
Fixes #65