chore: migrate uncompressed resources data #863
Merged
+292
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
force-pushed
the
compress-uncompressed
branch
2 times, most recently
from
bcb4fc1 to
ee1cde9
Compare
smira
previously approved these changes
Jan 22, 2025
DmitriyMV
force-pushed
the
compress-uncompressed
branch
from
ee1cde9 to
d053989
Compare
utkuozdemir
approved these changes
Jan 23, 2025
I wanted to preserve type safety so it was either duplicating code for different types or use generics. I tried to simplify the end result as much as I could |
Unix4ever
reviewed
Jan 23, 2025
DmitriyMV
force-pushed
the
compress-uncompressed
branch
2 times, most recently
from
1a2d462 to
71aedb0
Compare
|
@smira @Unix4ever should be good to go |
DmitriyMV
force-pushed
the
compress-uncompressed
branch
from
71aedb0 to
6d88df6
Compare
Closed
DmitriyMV
force-pushed
the
compress-uncompressed
branch
4 times, most recently
from
f327f21 to
a774ea0
Compare
|
Now the clusterInfo fails 🤦 |
Unix4ever
approved these changes
Jan 27, 2025
DmitriyMV
force-pushed
the
compress-uncompressed
branch
from
a774ea0 to
f08b52d
Compare
Abusing generics to compress uncompressed data in `*omni.ConfigPatch`, `*omni.ClusterMachineConfig`, `*omni.RedactedClusterMachineConfig` and `*omni.ClusterMachineConfigPatches`. Fixes siderolabs#853 Signed-off-by: Dmitriy Matrenichev <[email protected]>
DmitriyMV
force-pushed
the
compress-uncompressed
branch
from
f08b52d to
e2e5f08
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abusing generics to compress uncompressed data in
*omni.ConfigPatch,*omni.ClusterMachineConfig,*omni.RedactedClusterMachineConfigand*omni.ClusterMachineConfigPatches.Fixes #853