fix: improve emulator cloud provider reliability #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
force-pushed
the
cloud-provider-mode-fixes
branch
2 times, most recently
from
edecbfe
to
653dae5
Compare
Unix4ever
changed the title
Copy the labels from machine request to the machine request status. Use a single client for rtnetlink watches and management. Retry service account creation. Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
cloud-provider-mode-fixes
branch
from
653dae5
to
749f8e4
Compare
|
I don't know how hard would it be, but it might be also cool to use a single controller instance for all emulated machines if possible... but I know we want to keep separate states, to it becomes tricky. |
smira
approved these changes
Aug 17, 2024
Having a single controller for all machine level logic you mean? |
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the labels from machine request to the machine request
status.
Use a single client for rtnetlink watches and management.
Retry service account creation.