refactor cluster create command (frontend only) #10334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If KVM is not available, log a warning and proceed without it (instead of a hard error). This is useful for people who's machine doesn't support KVM. Signed-off-by: Orzelius <[email protected]>
User facing changes: * Add two sub-commands: "cluster create qemu" and "cluster create docker" The commands only have flags relevant to the applicable providers * Error if invalid provider's flags are passed * Add (QEMU only) or (docker only) at the start of the flag description * Group flags by providers and then sort alphabetically. Internal: * Split common cluster creation logic into a ClusterMaker abstraction * Split creation logic of cluster and qemu clusters * Add basic unit tests for all the options unrelated * Use default kubeconfig instead of kubeconfig.SinglePath() * If KVM is not available, log a warning and proceed without it Signed-off-by: Orzelius <[email protected]>
Orzelius
commented
Feb 11, 2025
|
|
||
| var testedFields = []string{} | ||
|
|
||
| func TestAllOptionFields(t *testing.T) { |
There was a problem hiding this comment.
Test that there are tests for all the common fields.
Please let me know if this is inappropriate or if there's a less hacky way to achieve the same result or if I should just change it to good ol' fashioned tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10289
related: #10133, #10287
Changes
User facing
cluster create qemuandcluster create dockercluster createstill functions all the same)cluster createcommands) (previously not all the flags were checked). This is technically a breaking change. Please let me know if it should be a warning at first.(QEMU only)or(docker only)at the start of the flag descriptioncluster create -h) group flags by providers and then sort alphabetically.See results to the command documentation in the reference docs
Internal
clustermakerpackageother
kubeconfig.SinglePath()which errors if multiple configs are definedNotes to reviewers
This might look like a massive change, but it's mostly just moving existing logic around with added tests. I've failed to get the integration tests running locally, so I'd love to see the results of a ci run and will fix any issues if they come up. As I can't perform thorough qemu testing on my mac machine I'm fairly certain some bugs remain, but they should be easy to fix once found thanks to the testable logic and clear separation of concerns.
Please let me know if I've missed something or if you have any ideas <3