-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/dropdown): adjusted height for dropdown (siemens#1671) #1762
base: main
Are you sure you want to change the base?
fix(core/dropdown): adjusted height for dropdown (siemens#1671) #1762
Conversation
🦋 Changeset detectedLatest commit: 8592fca The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, looks like your screenshots for testing are generated with windows. You have to generate it via a linux based system: https://github.com/siemens/ix/blob/main/CONTRIBUTING.md#visual-regression-testing
@varun-srinivasa did you consider to use a component test instead of an visual-regression test? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual regression tests of other components that utilise the ix-dropdown fail with these changes. Please review them and decide if these changes need to be fixed or the snapshots need to be udpted.
💡 What is the current behavior?
GitHub Issue Number: #1671
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support