Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown): adjusted height for dropdown (siemens#1671) #1762

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

varun-srinivasa
Copy link
Contributor

💡 What is the current behavior?

GitHub Issue Number: #1671

🆕 What is the new behavior?

  • Change max-height of dropdown from 50vh to calc(50vh - 50px)
  • Added visual regression test cases

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 8592fca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, looks like your screenshots for testing are generated with windows. You have to generate it via a linux based system: https://github.com/siemens/ix/blob/main/CONTRIBUTING.md#visual-regression-testing

@danielleroux
Copy link
Collaborator

danielleroux commented Mar 11, 2025

@varun-srinivasa did you consider to use a component test instead of an visual-regression test?

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual regression tests of other components that utilise the ix-dropdown fail with these changes. Please review them and decide if these changes need to be fixed or the snapshots need to be udpted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants