-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/tabs): added wheel support for tabs' sliding window #1786
base: main
Are you sure you want to change the base?
feat(core/tabs): added wheel support for tabs' sliding window #1786
Conversation
… and iOS WebView.
|
…thub.com:RamVinayMandal/ix into feat-1014/tabs-overflow-with-mouse-wheel-support
…thub.com:RamVinayMandal/ix into feat-1014/tabs-overflow-with-mouse-wheel-support
…thub.com:RamVinayMandal/ix into feat-1014/tabs-overflow-with-mouse-wheel-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scrolling feels a little weird. Hopefully the clip can illustrate that.
In essence the scroll appears to accelerate the longer one scrolls, even if the speed stays the same.
https://github.com/user-attachments/assets/2d505b16-b908-4cba-9716-0f12065bf734
…enhanced type safety.
…thub.com:RamVinayMandal/ix into feat-1014/tabs-overflow-with-mouse-wheel-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tab movement still lags behind the touch pointer. It would be great if the tab would always be underneath the finger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Touch scroll looks good now. But trackpad scroll still is not really working. It should behave just as a regular scrollbar would.
Thanks for the feedback — touch is smooth now, and trackpad scroll has been refined to behave like a regular scrollbar. |
|
💡 What is the current behavior?
GitHub Issue Number: #1014
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support