Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/tabs): added wheel support for tabs' sliding window #1786

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

RamVinayMandal
Copy link
Contributor

@RamVinayMandal RamVinayMandal commented Mar 19, 2025

💡 What is the current behavior?

  • No support for tabs' sliding using mouse wheel.

GitHub Issue Number: #1014

🆕 What is the new behavior?

  • Added mouse wheel scroll support for tabs, ensuring compatibility with iOS Safari and iOS WebView.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: 64c5d50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RamVinayMandal RamVinayMandal changed the title Added wheel support for tabs, including compatibility with iOS Safari… feat(core/tabs): added wheel support for tabs' sliding window Mar 19, 2025
@RamVinayMandal RamVinayMandal marked this pull request as ready for review March 26, 2025 10:09
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scrolling feels a little weird. Hopefully the clip can illustrate that.
In essence the scroll appears to accelerate the longer one scrolls, even if the speed stays the same.
https://github.com/user-attachments/assets/2d505b16-b908-4cba-9716-0f12065bf734

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab movement still lags behind the touch pointer. It would be great if the tab would always be underneath the finger.

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Touch scroll looks good now. But trackpad scroll still is not really working. It should behave just as a regular scrollbar would.

@RamVinayMandal
Copy link
Contributor Author

Thanks for the feedback — touch is smooth now, and trackpad scroll has been refined to behave like a regular scrollbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants