Improve containerized codecommit support. #106
Conversation
SetupHome overrides what is done in the container-entrypoint script. Disable it so that this setup phase is kept in a single place. Signed-off-by: Liam Beguin <[email protected]>
Add support for AWS codecommit remotes in containerized builds. This allows users to clone repositories using codecommit:// remotes. According to AWS documentation, `git-remote-codecommit` is the recommended method for supporting connections made with federated access, identity providers, and temporary credentials Signed-off-by: Liam Beguin <[email protected]>
Allow the containerized build to leverage the host SSO tokens, just like it's done for SSH configurations and keys. Signed-off-by: Liam Beguin <[email protected]>
Allow the containerized build to leverage the host's git-credentials, just like it's done for SSH configurations and keys. Signed-off-by: Liam Beguin <[email protected]>
|
Thanks for your contribution. But could you be a bit more verbose in your descriptions? Already the very first patch leaves me a bit clueless why exactly this this is now needed with this codecommit. But also what codecommit is (some link?), why one want this, that is also missing, e.g. in patch series header / PR description. For a broader discussion, it would be good to send the series via git send-email to our mailing list. |
|
Hi @jan-kiszka, Thanks for taking a look at this. Apologies for not adding more context to the description. I apologize also for not sending to the mailing list, I overlooked the CONTRIBUTING document. I'll rework and send there. Should we consider disabling github PR on the repo if the mailing list is the preferred way? |
|
I don't remember any follow-ups - were there any? Regarding PRs: I don't think this can be disabled on GH (in contrast to gitlab). |
No description provided.