Workaround for incorrect DBus activation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The broker implements DBus activation. However, it appears on the bus before it can fully be used (i.e. before the /com/microsoft/identity/broker1 becomes visible). By that, the buffered API calls are dispatched too early and return with an UnknownObject error. This affects both the introspection and API calls. To work around this, we poll for the path to show up before performing any other broker communication. Once the broker disappears, we clear our internal state to ensure the polling happens again before the next invocation. This logic makes it possible to run the broker only when needed and also solves issues around the initial startup of the broker via the web extension. Signed-off-by: Felix Moessbauer <[email protected]>
Previously, we precisely tracked the broker state and logged the user out in case the broker disappeared. This however made it impossible to auto-disable the broker after some time and only re-enable it when needed again. Now, we keep the user logged in once the frontend communicated once with the broker. When needed again, we just call into the backend and let it handle the startup, waiting and errors. Signed-off-by: Felix Moessbauer <[email protected]>
jan-kiszka
reviewed
Sep 21, 2024
|
Looks good in general, just a clarification if the poll rate is reasonable should be done. |
jan-kiszka
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broker implements DBus activation. However, it appears on the bus before it can fully be used (i.e. before the
/com/microsoft/identity/broker1becomes visible). By that, the buffered API calls are dispatched too early and return with an UnknownObjecterror. This affects both the introspection and API calls.
To work around this, we poll for the path to show up before performing any other broker communication. Once the broker disappears, we clear our internal state to ensure the polling happens again before the next invocation.
Closes: #33