chore: integrate automaxprocs/maxprocs with zerolog #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 80.25% 80.18% -0.08%
==========================================
Files 89 89
Lines 3748 3749 +1
==========================================
- Hits 3008 3006 -2
- Misses 534 536 +2
- Partials 206 207 +1 ☔ View full report in Codecov by Sentry. |
Log messages from automaxprocs/maxprocs are now seamlessly integrated into our existing logging framework. Previously, automaxprocs/maxprocs relied solely on `printf` for outputting messages directly to stdout. This approach bypassed any user-defined log levels, leading to potential issues in log verbosity and management. Signed-off-by: Michael Adler <[email protected]>
michaeladler
force-pushed
the
chore/gomaxprocs-logging
branch
from
b165bac to
d6ef400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log messages from automaxprocs/maxprocs are now seamlessly integrated into our existing logging framework.
Previously, automaxprocs/maxprocs relied solely on
printffor outputting messages directly to stdout. This approach bypassed any user-defined log levels, leading to potential issues in log verbosity and management.Issues Addressed
List and link all the issues addressed by this PR.
Change Type
Please select the relevant options:
Checklist