Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wfx does not start if built without plugin tag #198

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

michaeladler
Copy link
Member

@michaeladler michaeladler commented Jul 26, 2024

Description

wfx does not start if built without plugin tag

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

@michaeladler michaeladler requested a review from stormc as a code owner July 26, 2024 08:50
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (036d0ad) to head (cec0070).

Files Patch % Lines
cmd/wfx/cmd/root/plugins_enabled.go 87.50% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files         107      108    +1     
  Lines        3801     3801           
=======================================
  Hits         3196     3196           
  Misses        387      387           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaeladler michaeladler force-pushed the fix/no-plugins branch 2 times, most recently from c91bd19 to 240a3df Compare July 26, 2024 09:18
@stormc stormc merged commit b66e132 into siemens:main Jul 26, 2024
14 checks passed
@michaeladler michaeladler deleted the fix/no-plugins branch September 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants