Refactor build process #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 80.09% 72.45% -7.65%
==========================================
Files 92 100 +8
Lines 4305 4759 +454
==========================================
Hits 3448 3448
- Misses 628 1082 +454
Partials 229 229 ☔ View full report in Codecov by Sentry. |
stormc
reviewed
Feb 28, 2025
stormc
approved these changes
Feb 28, 2025
Signed-off-by: Michael Adler <[email protected]>
Change build tags from opt-in to opt-out. Previously, features like persistence storage backends required explicit build tags to be included. This change simplifies the build process by enabling all features by default and requiring build tags only to disable features. For example, the `no_mysql` build tag disables MySQL support. As a result, we can now simply run `go build` to build the wfx binary. Signed-off-by: Michael Adler <[email protected]>
Switch to using `go build` directly to embrace the Go way of building. This change eliminates the need to maintain both the Makefile and the goreleaser yaml. You can still build everything at once using the provided justfile with `just build`. Additionally, remove the go.mod files in subdirectories to avoid manual updates when the main go.mod is updated. As a result, the linter now also checks the contrib files, necessitating a few trivial fixes. Signed-off-by: Michael Adler <[email protected]>
michaeladler
force-pushed
the
feat/improve-build-process
branch
from
6f70786 to
6341a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go buildinsteadgo.modfiles from subdirectoriescontribis now being linted as well)Issues Addressed
List and link all the issues addressed by this PR.
Change Type
Please select the relevant options:
Checklist