Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin entgo version for stable codegen #82

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

michaeladler
Copy link
Member

@michaeladler michaeladler commented Nov 20, 2023

Description

The current "latest is greatest" approach breaks our CI pipelines forcing us to upgrade entgo as soon as a new version has been released. We use dependabot to keep our dependencies updated though.

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

@michaeladler michaeladler requested a review from stormc as a code owner November 20, 2023 15:33
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e9c8ec) 79.82% compared to head (6332bc6) 79.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files          80       80           
  Lines        3033     3033           
=======================================
  Hits         2421     2421           
  Misses        443      443           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stormc stormc merged commit 0da23ea into siemens:main Nov 20, 2023
@michaeladler michaeladler deleted the chore/pin-ent branch November 20, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants