Fix data #48
Merged
Fix data #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command "Group.query" was removed from aiida_core already in version 1.0.0. We never realised that it was used in the functions get_psf_groups, get_psml_groups, get_psf_family_names and get_psml_family_names. They are not so used therefore it is not a big concern, but probably it should be reported as a bug of out latest release.
…up system. From aiida 1.2.0 the class `Group` have been modified to implement new features. This has implications in our plugin because the PseudoFamilies are Groups. In particular there is now an explicit implementation of PsmlFamily and PsfFamily as subclasses of the `Group` class. Moreover PsmlFamily and PsfFamily are registred as entry points making possible to reload the correct sub class when reloading from the database. For more info see: aiidateam/aiida-core#3882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From aiida 1.2.0 the class
Grouphave been modified to implement new features.This has implications in our plugin because the PseudoFamilies are Groups.
In particular there is now an explicit implementation of PsmlFamily and PsfFamily
as sub-classes of the
Groupclass. Moreover PsmlFamily and PsfFamily areregistered as entry points making possible to reload the correct
sub class when reloading from the database.
For more info see: aiidateam/aiida-core#3882