ENG-4766:Add trivy to SDK CI build #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 23.27% 23.27%
=======================================
Files 11 11
Lines 1366 1366
Branches 321 321
=======================================
Hits 318 318
Misses 1048 1048 ☔ View full report in Codecov by Sentry. |
JMkrish
force-pushed
the
ENG-4766
branch
5 times, most recently
from
511921a to
6251f82
Compare
mklein0
approved these changes
Mar 26, 2024
| path: fs_report_master.html | ||
| # The following will mark the build as failed if there are issues in the report. | ||
| - sm-build/trivy_notify_on_issues: | ||
| slack_channel: monitoring-sdk |
There was a problem hiding this comment.
The only question I have is should this be a separate channel, or should be piggy back on the MA Monitoring channel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s), Design Docs, other Relevant Artifacts:
Description
This PR performs a security audit using an open source tool called Trivy. A repository scan is run every commit and a scan of the repository and latest image for the main/master branch is run nightly.
For the the nightly build, if there are issues reported, a slack message is generated to the monitoring-sdk slack channel. The message looks like this:
The Slack user display name will be changed to "CircleCI Build Bot".
Examples of the reports in HTML can be seen here in the artifacts tab: https://app.circleci.com/pipelines/github/sightmachine/sightmachine-sdk/417/workflows/d826285e-3a79-49a8-be1d-76e0aa65f7e8/jobs/1089
A number of legacy integrations were upgraded as part of maintaining tech-debt in the build system:
The tuning of the trivy report can be handled in a separate ticket.
Testing
This was manually tested via the CircleCI build process. A log of the test are cached in CircleCI under the branch.
To test yourself, replay an existing build or clone the branch and push.
To test the cve-image-scan job, attach it to the commit build.
Documentation
A markdown readme about configuring Trivy for developers / QA has been added.