Add a command to download any SRS files of any size #37
Conversation
ppoliani
changed the title
There was a problem hiding this comment.
Thanks so much for the PR! I also apologize because I know I'm on the hook to review the other ones :)
In addition to the comment I pointed out, I'm wondering if we want to follow this direction. So the question is: do we want to let the application manage the SRS, or do we want the user to do so? In the latter case, we would just ask the user to pass a path to the SRS.
I like the latter path for two reasons:
- some applications might want to use their own SRS
- the
request::getis probably much less optimized than awgetfor large files (and some of the useful SRS can get really large!)
wdyt?
| let srs_path = download_srs().await; | ||
|
|
||
| // always check integrity of file | ||
| let hash = sha256::try_digest(&srs_path).unwrap(); |
There was a problem hiding this comment.
IMO we should keep the checks on the digest!
|
@mimoo I don't have a particular preference to be honest. What you say make sense to me. In fact the first version of this PR worked the way you described 😆 Let me revert some of the commits. |
ppoliani
force-pushed
the
refactor/remove_srs
branch
from
4676353
to
c116a10
Compare
|
@mimoo I've removed the new command. Users would have to provide the |
| @@ -26,6 +26,14 @@ To install `snarkjs`, just run: | |||
| npm install -g snarkjs@latest | |||
| ``` | |||
|
|
|||
| ### Download SRS File | |||
|
|
|||
| To create a ZKP you would need to download the correct SRS file (based on your circuit size). For example, if your circuit has around 65K constraints then you would need to download the following file https://storage.googleapis.com/zkevm/ptau/powersOfTau28_hez_final_16.ptau. | |||
There was a problem hiding this comment.
sorry for the slow review, we should add a link to https://github.com/iden3/snarkjs#7-prepare-phase-2 which is more user friendly
There was a problem hiding this comment.
also it'd be good to add a wget premade command for the lazy asses
Delegate the downloading of SRS files to the end-user.
Based on the discussion here #36 and here #7