Skip to content

Commit

Permalink
fix(pose-viewer): render event after render, not before
Browse files Browse the repository at this point in the history
  • Loading branch information
AmitMY committed Nov 11, 2023
1 parent 2cf49eb commit b4b4e31
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/js/pose_viewer/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pose-viewer",
"version": "0.7.3",
"version": "0.7.4",
"description": "Stencil Component Starter",
"main": "dist/index.cjs.js",
"module": "dist/index.js",
Expand Down
7 changes: 2 additions & 5 deletions src/js/pose_viewer/src/components/pose-viewer/pose-viewer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ export class PoseViewer {
const frameId = Math.floor(currentTime * this.pose.body.fps);
const frame = this.pose.body.frames[frameId];

const render = this.renderer.render(frame);
if (!this.hasRendered) {
requestAnimationFrame(() => {
this.hasRendered = true;
Expand All @@ -325,11 +326,7 @@ export class PoseViewer {
}
requestAnimationFrame(() => this.render$.emit());

return (
<Host>
{this.renderer.render(frame)}
</Host>
);
return (<Host>{render}</Host>);
}
}

Expand Down
5 changes: 5 additions & 0 deletions src/js/pose_viewer/src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@
poseViewer.setAttribute('src', url + 'test');
}, 2000);

poseViewer.addEventListener('render$', (e) => {
console.log(poseViewer.shadowRoot.querySelector('canvas').width);
console.log(poseViewer.shadowRoot.querySelector('canvas').height);
});


// for(let i = 0; i < sentence.length; i++) {
// setTimeout(() => {
Expand Down

0 comments on commit b4b4e31

Please sign in to comment.