Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usability improvements #118

Merged
merged 2 commits into from
Sep 23, 2024
Merged

usability improvements #118

merged 2 commits into from
Sep 23, 2024

Conversation

bipinkrish
Copy link
Contributor

@bipinkrish bipinkrish commented Sep 19, 2024 •
edited
Loading

@bipinkrish
usability improvements (#1)
d78a13a 
* add node types

* update types

* handle different sources

* export PoseViewer class

* create js tests workflow

* update js workflow

* add run command

* test for pose format

* remove comma

* update package-lock.json

* update test lib

* add puppeteer

* remove node 14 test

* no tests file
AmitMY
AmitMY requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

src/js/pose_viewer/src/components/pose-viewer/pose-viewer.tsx Outdated Show resolved Hide resolved
src/js/pose_viewer/src/components/pose-viewer/pose-viewer.tsx Outdated Show resolved Hide resolved
@bipinkrish
Copy link
Contributor Author

should be okay now

@AmitMY AmitMY merged commit b72b09f into sign-language-processing:master Sep 23, 2024
4 checks passed
@AmitMY
Copy link
Collaborator

AmitMY commented Sep 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitMY AmitMY AmitMY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bipinkrish @AmitMY