Feature/dataset deprecation (and comments on datasets.js) #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2024 12:36
cleong110
changed the title
AmitMY
requested changes
Jun 20, 2024
|
Added a v2, took out as many redundant comments as I could. Are the remaining ones correct? |
AmitMY
requested changes
Jun 21, 2024
|
All right! Made some more updates! Thanks for guidance/suggestions! |
AmitMY
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on local testing, it seems to successfully skip datasets with "status":"deprecated". Datasets without status fields are left alone.
Also added significant commenting to datasets.js.
Closes #91.
Closes #66