Skip to content

Add imperative make local [WIP] #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

davixcky
Copy link
Contributor

@davixcky davixcky commented Mar 3, 2025

Usage

signadot sb make-local --cluster signadot-staging -w workspaces/web --port-mapping 80:3000 --port-mapping 2000:2020

signadot sb make-local --cluster signadot-staging -w workspaces/web --port-mapping 80:"localhost:3000" 

signadot sb make-local --cluster signadot-staging -w workspaces/web --port-mapping 80:3000 my_custom_sandbox

Screenshot 2025-03-03 at 8 17 28 AM

Questions
Do we need a TTL for local sandboxes?
I believe we do, as this allows us to clean up local sandboxes automatically. However, we then need to determine if and how we can reliably track that state.

Should we allow specifying multiple workloads?
In my view, supporting multiple workloads introduces unnecessary complexity and detracts from the simplicity we’re aiming for.

Finally, I think we should add an interactive prompt. Initially, I considered doing this later, but I now feel it would be better to include it from the start.

@davixcky davixcky changed the title add imperative make local Add imperative make local Mar 3, 2025
@davixcky davixcky changed the title Add imperative make local Add imperative make local [WIP] Mar 3, 2025
@davixcky davixcky marked this pull request as draft March 3, 2025 13:34
@davixcky davixcky marked this pull request as ready for review March 3, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant