-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from templ to react app #235
Conversation
Sandbox Ready! |
@davixcky , the page title is wrong: |
I guess when you request a driver, the notification accordion should open by default |
Here is a bug: screen-capture.15.webmSame thing if I empty the pick up location instead of drop off. |
@daniel-de-vera all comments has been addressed |
@davixcky, from what I understand we are not using:
Can we remove those things? (to keep the code clean) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I would wait for @foxish approval to merge it.
Is the sandbox preview for this PR working? I couldn't get it to happen on http://frontend.hotrod-istio.svc:8080/ with the header |
One suggestion, can we make the log appear on top, and the map below it? Just to ensure there's visibility of the log, and that the map occupies only 50% of the viewport. WDYT? Also I was looking for preview in the wrong spot - the sandbox is on top of http://frontend.hotrod-devmesh.svc:8080/ - because this PR doesn't have the |
LGTM, thanks! |
Screen.Recording.2024-03-07.at.9.01.15.PM.mov