Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from templ to react app #235

Merged
merged 9 commits into from
Mar 11, 2024
Merged

move from templ to react app #235

merged 9 commits into from
Mar 11, 2024

Conversation

davixcky
Copy link
Contributor

@davixcky davixcky commented Mar 8, 2024

  • add react app
  • serve react app
Screen.Recording.2024-03-07.at.9.01.15.PM.mov

Copy link

github-actions bot commented Mar 8, 2024

@daniel-de-vera
Copy link
Contributor

@davixcky , the page title is wrong:

Screenshot from 2024-03-08 12-21-54

@daniel-de-vera
Copy link
Contributor

I guess when you request a driver, the notification accordion should open by default

@daniel-de-vera
Copy link
Contributor

daniel-de-vera commented Mar 8, 2024

Here is a bug:

screen-capture.15.webm

Same thing if I empty the pick up location instead of drop off.

@davixcky
Copy link
Contributor Author

davixcky commented Mar 8, 2024

@daniel-de-vera all comments has been addressed

@daniel-de-vera
Copy link
Contributor

@davixcky, from what I understand we are not using:

  • services/frontend/static/*
  • services/frontend/templates/*

Can we remove those things? (to keep the code clean)

Copy link
Contributor

@daniel-de-vera daniel-de-vera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I would wait for @foxish approval to merge it.

@foxish
Copy link
Member

foxish commented Mar 8, 2024

Is the sandbox preview for this PR working? I couldn't get it to happen on http://frontend.hotrod-istio.svc:8080/ with the header

@foxish
Copy link
Member

foxish commented Mar 8, 2024

One suggestion, can we make the log appear on top, and the map below it? Just to ensure there's visibility of the log, and that the map occupies only 50% of the viewport. WDYT?

Also I was looking for preview in the wrong spot - the sandbox is on top of http://frontend.hotrod-devmesh.svc:8080/ - because this PR doesn't have the istio label set.

@foxish
Copy link
Member

foxish commented Mar 11, 2024

LGTM, thanks!

@foxish foxish merged commit bf854f5 into main Mar 11, 2024
7 checks passed
@foxish foxish deleted the move-from-templ-to-react-app branch March 11, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants