Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust kafka config settings #237

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

daniel-de-vera
Copy link
Contributor

This PR is in the context of https://github.com/signadot/signadot/issues/4232.
I adjusted some of the timeout settings from the kafka client config, and check for context cancellation in ConsumeClaim().

Copy link

github-actions bot commented Mar 12, 2024

Copy link
Member

@scott-cotton scott-cotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-de-vera daniel-de-vera merged commit 6b65d94 into main Mar 12, 2024
10 checks passed
@daniel-de-vera daniel-de-vera deleted the kafka-consumer-improvements branch March 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants