Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide schedules Media from ConversationSettings #13969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Feb 5, 2025

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Reasons for doing this:

  1. Schedules messages are not logically "shared" in the thread.
  2. We can go to the Media Preview Screen for Scheduled Image, which can allow us to delete a schedule message for everyone. So, possibility of a Deleted message is still scheduled.
  3. A scheduled media message is present in the MediaOverview, from where we can select and delete it, this cause inconsistencies with the scheduled message flow.
  4. Schedules Media message show the System.currentTimeMillis date for the media in MediaOverview screen but actually the media isn't sent yet!
    photo_6134124661139685546_y

So, now showing the Scheduled media is probably the best choice which other Messengers like Telegram also follow.

document_6134124660683444809.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant