Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

upstream unencrypted headers #5

Closed
wants to merge 7 commits into from

Conversation

michaelkirk-signal
Copy link

@michaelkirk-signal michaelkirk-signal commented Aug 1, 2018

If this looks good to you @charlesmchen, I'll open upstream.

I took https://github.com/signalapp/YapDatabase/tree/release/unencryptedHeaders and:

  1. rebased it ( no conflicts)
  2. removed 764e949 which is unrelated to unencrypted headers.

I'll investigate a bit and see if we can justify upstreaming it in a separate PR, or if we should just keep it in an extension in our own project.

@michaelkirk-signal
Copy link
Author

Upstream PR at yapstudios#466

@charlesmchen-signal
Copy link

It'd be nice to get in 764e949 one way or another since we use it in our tests.

Note that we may need to update our tests a little anyway.

Copy link

@charlesmchen-signal charlesmchen-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelkirk-signal
Copy link
Author

It'd be nice to get in 764e949 one way or another since we use it in our tests.

I exposed them in the category extension local to the test.

signalapp/Signal-iOS@ae488d3#diff-23ab48e4becf5545cca1bc6bd2066d1bL16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants