Skip to content

Commit

Permalink
Merge pull request #96 from signalfx/casting
Browse files Browse the repository at this point in the history
add functions to cast primitives to their appropriate datapoint value
  • Loading branch information
charless-splunk authored Jun 5, 2018
2 parents 7d77b32 + 08559e3 commit b1be94c
Show file tree
Hide file tree
Showing 2 changed files with 289 additions and 0 deletions.
71 changes: 71 additions & 0 deletions datapoint/cast.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
package datapoint

import (
"fmt"
)

// CastIntegerValue casts a signed integer to a datapoint Value
func CastIntegerValue(value interface{}) (metricValue Value, err error) {
switch val := value.(type) {
case int64:
metricValue = intWire(val)
case int32:
metricValue = intWire(int64(val))
case int16:
metricValue = intWire(int64(val))
case int8:
metricValue = intWire(int64(val))
case int:
metricValue = intWire(int64(val))
default:
err = fmt.Errorf("unknown metric value type %T", val)
}
return
}

// CastUIntegerValue casts an unsigned integer to a datapoint Value
func CastUIntegerValue(value interface{}) (metricValue Value, err error) {
switch val := value.(type) {
case uint64:
metricValue = intWire(int64(val))
case uint32:
metricValue = intWire(int64(val))
case uint16:
metricValue = intWire(int64(val))
case uint8:
metricValue = intWire(int64(val))
case uint:
metricValue = intWire(int64(val))
default:
err = fmt.Errorf("unknown metric value type %T", val)
}
return
}

// CastFloatValue casts a float to datapoint Value
func CastFloatValue(value interface{}) (metricValue Value, err error) {
switch val := value.(type) {
case float64:
metricValue = floatWire(val)
case float32:
metricValue = floatWire(float64(val))
default:
err = fmt.Errorf("unknown metric value type %T", val)
}
return
}

// CastMetricValue casts an interface to datapoint Value
func CastMetricValue(value interface{}) (metricValue Value, err error) {
switch val := value.(type) {
case int64, int32, int16, int8, int:
metricValue, err = CastIntegerValue(value)
case uint64, uint32, uint16, uint8, uint:
metricValue, err = CastUIntegerValue(value)
case float64, float32:
metricValue, err = CastFloatValue(value)
default:
err = fmt.Errorf("unknown metric value type %T", val)
}
return
}
218 changes: 218 additions & 0 deletions datapoint/cast_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,218 @@
package datapoint

import (
"reflect"
"testing"
)

func TestCastMetricValue(t *testing.T) {
type args struct {
value interface{}
}
tests := []struct {
name string
args args
wantMetricValue Value
wantErr bool
}{
{
name: "cast float32 to int value",
args: args{
value: float32(1),
},
wantMetricValue: NewFloatValue(float64(1)),
},
{
name: "cast float64 to int value",
args: args{
value: float64(2),
},
wantMetricValue: NewFloatValue(float64(2)),
},
{
name: "cast uint to int value",
args: args{
value: uint(4),
},
wantMetricValue: NewIntValue(int64(4)),
},
{
name: "cast uint8 to int value",
args: args{
value: uint8(5),
},
wantMetricValue: NewIntValue(int64(5)),
},
{
name: "cast uint16 to int value",
args: args{
value: uint16(6),
},
wantMetricValue: NewIntValue(int64(6)),
},
{
name: "cast uint32 to int value",
args: args{
value: uint32(7),
},
wantMetricValue: NewIntValue(int64(7)),
},
{
name: "cast uint64 to int value",
args: args{
value: uint64(8),
},
wantMetricValue: NewIntValue(int64(8)),
},
{
name: "cast int to int value",
args: args{
value: int(10),
},
wantMetricValue: NewIntValue(int64(10)),
},
{
name: "cast int8 to int value",
args: args{
value: int8(11),
},
wantMetricValue: NewIntValue(int64(11)),
},
{
name: "cast int16 to int value",
args: args{
value: int16(12),
},
wantMetricValue: NewIntValue(int64(12)),
},
{
name: "cast int32 to int value",
args: args{
value: int32(13),
},
wantMetricValue: NewIntValue(int64(13)),
},
{
name: "cast int64 to int value",
args: args{
value: int64(14),
},
wantMetricValue: NewIntValue(int64(14)),
},
{
name: "cast metric value error",
args: args{
value: "hello world",
},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotMetricValue, err := CastMetricValue(tt.args.value)
if (err != nil) != tt.wantErr {
t.Errorf("CastMetricValue() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(gotMetricValue, tt.wantMetricValue) {
t.Errorf("CastMetricValue() = %v, want %v", gotMetricValue, tt.wantMetricValue)
}
})
}
}

func TestCastFloatValue(t *testing.T) {
type args struct {
value interface{}
}
tests := []struct {
name string
args args
wantMetricValue Value
wantErr bool
}{
{
name: "cast float err",
args: args{
value: int64(3),
},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotMetricValue, err := CastFloatValue(tt.args.value)
if (err != nil) != tt.wantErr {
t.Errorf("CastFloatValue() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(gotMetricValue, tt.wantMetricValue) {
t.Errorf("CastFloatValue() = %v, want %v", gotMetricValue, tt.wantMetricValue)
}
})
}
}

func TestCastUIntegerValue(t *testing.T) {
type args struct {
value interface{}
}
tests := []struct {
name string
args args
wantMetricValue Value
wantErr bool
}{
{
name: "cast uint error",
args: args{
value: int64(9),
},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotMetricValue, err := CastUIntegerValue(tt.args.value)
if (err != nil) != tt.wantErr {
t.Errorf("CastUnsignedIntegerValue() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(gotMetricValue, tt.wantMetricValue) {
t.Errorf("CastUnsignedIntegerValue() = %v, want %v", gotMetricValue, tt.wantMetricValue)
}
})
}
}

func TestCastIntegerValue(t *testing.T) {
type args struct {
value interface{}
}
tests := []struct {
name string
args args
wantMetricValue Value
wantErr bool
}{
{
name: "cast int error",
args: args{
value: uint64(15),
},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotMetricValue, err := CastIntegerValue(tt.args.value)
if (err != nil) != tt.wantErr {
t.Errorf("CastIntegerValue() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(gotMetricValue, tt.wantMetricValue) {
t.Errorf("CastIntegerValue() = %v, want %v", gotMetricValue, tt.wantMetricValue)
}
})
}
}

0 comments on commit b1be94c

Please sign in to comment.