Skip to content

Commit

Permalink
Fix deployment in GKE Autopilot (#1071)
Browse files Browse the repository at this point in the history
For some reason the metrics-addr argument was brought back into the exception rules in GKE Autopilot side for both log engine modes. For now bring the argument back to fix the failing deployment
  • Loading branch information
dmitryax authored Dec 8, 2023
1 parent 5a30f95 commit 80dfb49
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
8 changes: 8 additions & 0 deletions .chloggen/fix-gke-autopilot-deployment.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, networkExplorer, operator, chart, other)
component: agent
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix GKE Autopilot deployment
# One or more tracking issues related to the change
issues: [1071]
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ spec:
command:
- /otelcol
- --config=/conf/relay.yaml
- --metrics-addr=0.0.0.0:8889
ports:
- name: jaeger-grpc
containerPort: 14250
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/splunk-otel-collector/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ spec:
{{- else }}
- /otelcol
- --config=/conf/relay.yaml
{{- if and (eq .Values.distribution "gke/autopilot") (eq .Values.logsEngine "fluentd") }}
{{- if eq .Values.distribution "gke/autopilot" }}
{{- /* Temporary no-op argument required to run collector on GKE Autopilot */}}
- --metrics-addr=0.0.0.0:8889
{{- end }}
Expand Down

0 comments on commit 80dfb49

Please sign in to comment.