Removing TODOs #75

evoke/examples/godfreysmith2013communication.py

@@ -701,7 +701,6 @@ def calculate_results_per_c_and_k(self) -> None:
         """
 
         # 1. Initialize
-        # TODO: get this from the keys of self.games.
         results = {
             f"{c_value:.3f}_{k_value:.3f}": []
             for c_value in self.c_values

evoke/src/evolve.py

@@ -520,15 +520,14 @@ def is_pooling(self, epsilon=1e-3):
 
         """
 
-        ## TODO: add a custom exception here.
         ## Check that the game is of the appropriate type for this method.
         ## i.e. In order to determine whether a simulation is currently pooling,
         ## there must minimally be states, signals and acts.
         assert (
             hasattr(self.game, "states")
             and hasattr(self.game, "messages")
             and hasattr(self.game, "acts")
-        )
+        ), "Game must have states, messages and acts to determine pooling."
 
         ##########################################################
         ## NB: This is not true because the state_chances might be uneven enough
@@ -709,7 +708,6 @@ def calculate_stats(self):
             self.statistics["avg_prob_success"][:] = np.nan
 
         ## Get the current average probability of success
-        # TODO check this!
         avg_prob_success = np.average(
             self.game.payoff(sender_strat=snorm, receiver_strat=rnorm)
         )

evoke/src/games.py

@@ -111,13 +111,6 @@ def receiver_pure_strats(self):
         pure_strats = np.identity(self.acts)
         return np.array(list(it.product(pure_strats, repeat=self.messages)))
 
-    def one_pop_pure_strats(self):
-        """
-        Return the set of pure strategies available to players in a
-        one-population setup
-        """
-        # TODO
-
     def payoff(self, sender_strat, receiver_strat):
         """
         Calculate the average payoff for sender and receiver given concrete