Add support for docker build caching, disabled by default #313
Conversation
| @@ -63,13 +63,9 @@ inputs: | |||
| default: 'false' | |||
| description: 'Generate tag only.' | |||
| required: false | |||
| CACHE_FROM: | |||
There was a problem hiding this comment.
these are not used by any consuming repos and not exposed in the ci workflows so removing them
| uses: docker/build-push-action@v6 | ||
| if: inputs.TAG_ONLY == 'false' |
There was a problem hiding this comment.
TAG_ONLY is never used as far as I can tell, in any consuming repos, so removing to simplify the flag logic
There was a problem hiding this comment.
TAG_ONLY looks to be used in workflows/cd-retag.yml. We should remove references to TAG_ONLY there as well.
ryanwi
changed the title
| uses: docker/build-push-action@v6 | ||
| if: inputs.TAG_ONLY == 'false' |
There was a problem hiding this comment.
TAG_ONLY looks to be used in workflows/cd-retag.yml. We should remove references to TAG_ONLY there as well.
| default: 'false' | ||
| description: 'Generate tag only.' | ||
| required: false |
There was a problem hiding this comment.
This input should be removed as well if we're eliminating TAG_ONLY entirely.
There was a problem hiding this comment.
i can keep it if we think it is or should be used? would need to understand the use case that led to it being added
There was a problem hiding this comment.
From what I can see, the only use I've seen so far is in the cd-retag workflow, which tags an existing image with another tag and pushes it. Let's keep things as-is for now.
Allow projects to use docker build cache