Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incoming calls #70

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Handle incoming calls #70

merged 4 commits into from
Mar 13, 2024

Conversation

jpsantosbh
Copy link
Contributor

@jpsantosbh jpsantosbh commented Mar 6, 2024 •
edited
Loading

  • Adds support to handle incoming calls over the WebSocket
  • Refactor dial() to include the rootElement
  • Refactor PN handling to use the safe incoming call notifications as over the WebSocket

Depends

signalwire/signalwire-js#979

@jpsantosbh jpsantosbh changed the title WIP: Handle incoming calls Handle incoming calls Mar 12, 2024
@jpsantosbh
Copy link
Contributor Author

Not merge before: signalwire/signalwire-js#979

@jpsantosbh jpsantosbh marked this pull request as ready for review March 12, 2024 20:09
@jpsantosbh
Copy link
Contributor Author

signalwire/signalwire-js#979 is merged and released already

iAmmar7
iAmmar7 reviewed Mar 13, 2024
View reviewed changes
public/full.js Outdated
if(!window.__client) {
window.__client = await getClient()
}
client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a mistake?

views/index.ejs Outdated Show resolved Hide resolved
jpsantosbh and others added 2 commits March 13, 2024 09:53
@jpsantosbh jpsantosbh merged commit bc0bf30 into main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iAmmar7 iAmmar7 iAmmar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpsantosbh @iAmmar7