Creating BytesMut with appropriate capacity in ENR Builder #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Sep 16, 2024
|
Just need to fix the clippy lints. I would have done it, but i can't seem to push to your master branch |
Signed-off-by: Archisman-Mridha <[email protected]>
Archisman-Mridha
force-pushed
the
master
branch
from
0d35708
to
b616bff
Compare
Fixed the clippy lint error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going through the sourcecode, trying to understand what are Ethereum Node Records (ENRs). Noticed that we can create
BytesMutspecifying the capacity everytime, in the ENR builder module.So here i made a PR :).