Improves ergonomics to allow removing fields from an ENR #84

AgeManning · 2024-10-22T06:06:43Z

As the title says, this adds functions to allow users to easily remove common fields on an ENR.

This also adds constants for constant strings used throughout the ENR.

jxs

LGTM, left some nits

src/builder.rs

src/lib.rs

Co-authored-by: João Oliveira <[email protected]>

src/lib.rs

AgeManning added 2 commits October 22, 2024 17:05

Improves ergonomics to allow removing fields from an ENR

fad7fbf

Merge latest master

11429e0

AgeManning requested a review from jxs October 23, 2024 05:07

jxs approved these changes Oct 24, 2024

View reviewed changes

divagant-martian reviewed Oct 24, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

AgeManning and others added 7 commits October 28, 2024 15:49

Update src/builder.rs

f790c02

Co-authored-by: João Oliveira <[email protected]>

Update src/lib.rs

6db73bf

Co-authored-by: João Oliveira <[email protected]>

Update src/lib.rs

38e03e3

Co-authored-by: João Oliveira <[email protected]>

Update src/lib.rs

ba3ea84

Co-authored-by: João Oliveira <[email protected]>

Update src/lib.rs

17484af

Co-authored-by: João Oliveira <[email protected]>

Update src/lib.rs

8963f58

Co-authored-by: João Oliveira <[email protected]>

Prevent ENR from being corruptable

6eeb694

jxs reviewed Oct 28, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

Cleaner approach to reverting on error when changing fields

bdfd7a9

AgeManning merged commit b033b92 into master Oct 29, 2024
9 checks passed

Provide feedback