Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfield::with_capacity fix OutOfBounds i field, plus doc typo fix #33

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

carver
Copy link
Contributor

@carver carver commented Sep 25, 2024

The OutOfBounds error was not filling the i field correctly, and the docs mistakenly said the method returns None instead of Err if the index is too large.

@carver carver changed the title docs: Bitfield::with_capacity returns Result not Option Bitfield::with_capacity fix OutOfBounds i field, plus doc typo fix Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (dc04526) to head (90ed130).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ssz/src/bitfield.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   77.48%   77.76%   +0.27%     
==========================================
  Files          12       12              
  Lines         715      715              
==========================================
+ Hits          554      556       +2     
+ Misses        161      159       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It was returning the max length twice, and now returns the actual length
and maximum length.
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@michaelsproul michaelsproul merged commit 46e266c into sigp:main Sep 26, 2024
7 checks passed
@carver carver deleted the patch-1 branch September 26, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants