Add gossipsub as a Lighthouse behaviour #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Jan 15, 2024
| libp2p-mplex = { git = "https://github.com/sigp/rust-libp2p/", rev = "b96b90894faab0a1eed78e1c82c6452138a3538a" } | ||
|
|
||
| [dependencies.libp2p] | ||
| git = "https://github.com/sigp/rust-libp2p/" |
There was a problem hiding this comment.
we can depend on sigp/rust-libp2p master after sigp/rust-libp2p#566 gets merged
AgeManning
force-pushed
the
lighthouse-behaviour
branch
from
324f873
to
39fbd19
Compare
AgeManning
force-pushed
the
lighthouse-behaviour
branch
from
39fbd19
to
f83f9b3
Compare
dapplion
added
the
waiting-on-author
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4273004 |
8 tasks
AgeManning
added
ready-for-merge
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Move gossipsub as a lighthouse behaviour * Update dependencies, pin to corrected libp2p version * Merge latest unstable * Fix test * Remove unused dep * Fix cargo.lock * Re-order behaviour, pin upstream libp2p * Pin discv5 to latest version
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves gossipsub into the
lighthouse_networkrepository.This allows us to move a little bit quicker and add lighthouse-specific changes to our gossipsub behaviour without worrying about upstream users who may depend on the code.
This currently introduced tracing as a logging dependency. We might want to consider shifting to slog, but still filtering the logs into a separate file.
I've left this as tracing log for the time being.
This PR also introduce the following changes to the gossipsub protocol:
ConnectionHandlermessage queue. The default is5000messages, but users can change that value viaConfig::connection_handler_queue_len()