Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a new
TreeHashMut
trait which takes&mut self
This might be a cleaner alternative to:
Although we got bogged down in the Milhouse changes, especially around supporting nested lists:
List<List<u64, N>, M>
is troublesome because theT
inList<T>
should probably implementTreeHashMut
, but we don't have mutable access to the elements of an immutable list.Another alternative might be to embrace interior mutability in Milhouse so that TreeHash can be implemented without mutation altogether.