Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor e2e-tests.yml workflow #3627

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Refactor e2e-tests.yml workflow #3627

merged 4 commits into from
Apr 9, 2024

Commits on Mar 28, 2024

  1. Move attach e2e tests into Go test suite 

    Run the e2e_test_attach.sh tests in Go, as a step toward making all the
e2e tests consistent with one another. This also has the added benefit
of no longer relying on ttl.sh since test images are hosted in the mock
registry server.

These tests were being run in CI under Linux and Mac, since they don't
rely on a Kind instance or any Sigstore services. This change updates
the GitHub workflow for the attach tests to simply run all e2e tests
that are compatible with the macos runner.

Signed-off-by: Colleen Murphy <[email protected]>
    @cmurphy
    cmurphy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fcce5a8 View commit details
    Browse the repository at this point in the history

  2. Reorganize cross-platform attach tests 

    Move all the e2e tests for cosign attachments that can be run
independently without other Sigstore services into the new
e2e_attach_test.go file, to make the main e2e_test.go file a more
mantainable size and to get the benefit of running these tests in the
e2e-cross job which runs on macos and linux.

Signed-off-by: Colleen Murphy <[email protected]>
    @cmurphy
    cmurphy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7cede6d View commit details
    Browse the repository at this point in the history

  3. Move TSA MTLS tests into Go test suite 

    Run the e2e_tsa_mtls.sh tests in Go. With this, a separate step to run
the script is unnecessary for the Github workflow, since it will be run
as part of the e2e-cross job.

Signed-off-by: Colleen Murphy <[email protected]>
    @cmurphy
    cmurphy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    69209ea View commit details
    Browse the repository at this point in the history

  4. Move TSA blob tests into Go test suite 

    Run the e2e_signblob_tsa_mtls.sh tests in Go. The e2e-tsa-mtls job in
the e2e-tests workflow is fully removed since these are now all covered
in e2e-cross.

Signed-off-by: Colleen Murphy <[email protected]>
    @cmurphy
    cmurphy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2f674bb View commit details
    Browse the repository at this point in the history