Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview.md #263

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

jonvnadelberg
Copy link
Collaborator

change verify to associates in one instance for consistency.

Partial fix for #262

Summary

Release Note

NONE

Documentation

Doc only for #262

change verify to associates in one instance for consistency.

Signed-off-by: jonvnadelberg <[email protected]>
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 7683b59
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/652eb25f148cb00008e51019
😎 Deploy Preview https://deploy-preview-263--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haydentherapper
Copy link
Contributor

What do you mean by associated? Linked to an identity?

@@ -1,4 +1,4 @@
---
rer---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. I'll remove it.

@jonvnadelberg
Copy link
Collaborator Author

What do you mean by associated? Linked to an identity?

Yes, this was the wording we settled on in a certain case instead of verified. You didn't want to use the word verified in a certain instance so we picked "associated." I thought the other uses of verified were ok, though, so I left them. Do you want to go back to verified? I can replace associated with verified.

remove typo error

Signed-off-by: jonvnadelberg <[email protected]>
@haydentherapper
Copy link
Contributor

I might rewrite that line, using single words rather than phrases doesn't convey much. What about something like:

"With Sigstore, the artifact is not just signed; it’s signed with an ephemeral key, associated with a known identity, and publicly auditable."

@jonvnadelberg
Copy link
Collaborator Author

I might rewrite that line, using single words rather than phrases doesn't convey much. What about something like:

"With Sigstore, the artifact is not just signed; it’s signed with an ephemeral key, associated with a known identity, and publicly auditable."

That sounds great. I'll change it.

Signed-off-by: jonvnadelberg <[email protected]>
@ltagliaferri ltagliaferri merged commit 501f84f into sigstore:main Oct 19, 2023
5 checks passed
@jonvnadelberg jonvnadelberg deleted the update-about-overview branch November 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants