fix: policy controller chart schema #904
Open
+62
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: falcorocks <[email protected]>
falcorocks
force-pushed
the
fix-schema
branch
from
093877c to
c6c1ecf
Compare
removes keys required and additonalProperties from the controller chart schema that were added by mistake in 142e34b see https://sigstore.slack.com/archives/C03096V09F1/p1737627750048369 Signed-off-by: falcorocks <[email protected]>
9 tasks
bobcallaway
reviewed
Feb 9, 2025
Comment on lines
+14
to
+15
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| with: | |
| persist-credentials: false |
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: setup go | ||
| uses: actions/setup-go@v5 |
There was a problem hiding this comment.
please pin this at the latest release commit
Comment on lines
+18
to
+19
| with: | ||
| go-version: '>=1.23.1' |
There was a problem hiding this comment.
i'd just remove this, since it will use the default go toolchain on the runner and that's sufficient for go install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR removes 2 keys from the chart schema that were added by mistake in 142e34b (probably through the helm-schema, see https://sigstore.slack.com/archives/C03096V09F1/p1737627750048369):
additionalPropertiesrequiredhelm-schemagives for granted that all values in thevalues.yamlare required and should not allow additionalProperties, which is pretty inflexible. We should ask users to runhelm-schema -k additionalProperties,requiredto avoid this from happening again. The PR also adds a new CI workflow to check that the schema has been generated with these flags. I've tested a failure on purpose here by messing with the schema and it worked. Notice that this test is limited to the policy controller only in this PR, if we are happy we can expand the test to cover all charts later.Existing or Associated Issue(s)
Originally implemented in #894
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.