-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a prototype for generating jsonschema files #112
Changes from 8 commits
e3f3dd8
c2e04f5
1a9f032
4f5b42d
2025521
240f520
8f605d6
fce50a6
56f3f97
8feb7bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# 3.18.2 | ||
FROM alpine@sha256:25fad2a32ad1f6f510e528448ae1ec69a28ef81916a004d3629874104f8a7f70 | ||
RUN apk add --update protoc=3.21.12-r2 protobuf-dev=3.21.12-r2 go=1.20.5-r0 git=2.40.1-r0 | ||
RUN go install github.com/chrusty/protoc-gen-jsonschema/cmd/[email protected] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you know if dependabot will suggest updates for Go dependencies in Dockerfiles? Otherwise we might want to add a hack like https://github.com/sigstore/rekor/blob/main/hack/tools/go.mod |
||
# This is required to get the field_behavior.proto file | ||
# NOTE: --filter=tree:0 performs a treeless clone; we do this to optimize cloning | ||
# this otherwise relatively heavy repository. | ||
RUN git clone --filter=tree:0 https://github.com/googleapis/googleapis.git | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NB: This repository doesn't appear to be versioned in any way, and isn't packaged in alpine. I could check out a fixed revision if we're like more consistency here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to pin it to a fixed revision. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, this is moderately annoying: we can't do a fast-path There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did it with a |
woodruffw marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#!/bin/sh | ||
|
||
set -u | ||
set -e | ||
|
||
protoc --plugin=/root/go/bin/protoc-gen-jsonschema \ | ||
--jsonschema_opt=enforce_oneof \ | ||
--jsonschema_opt=file_extension=schema.json \ | ||
--jsonschema_opt=disallow_additional_properties \ | ||
"$@" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-04/schema#", | ||
"$ref": "#/definitions/Artifact", | ||
"definitions": { | ||
"Artifact": { | ||
"properties": { | ||
"artifact_uri": { | ||
"type": "string", | ||
"description": "Location of the artifact" | ||
}, | ||
"artifact": { | ||
"type": "string", | ||
"description": "The raw bytes of the artifact", | ||
"format": "binary", | ||
"binaryEncoding": "base64" | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"type": "object", | ||
"oneOf": [ | ||
{ | ||
"required": [ | ||
"artifact_uri" | ||
] | ||
}, | ||
{ | ||
"required": [ | ||
"artifact" | ||
] | ||
} | ||
], | ||
"title": "Artifact" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: I picked these version numbers not because they're the most recent, but because they're consistent with Alpine's
world
version for the Alpine version chosen. More recent versions could probably be made to work, but I figured this was the path of least resistance.