python-release: use trusted publishing #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes sigstore#154. Signed-off-by: William Woodruff <[email protected]>
haydentherapper
approved these changes
Oct 19, 2023
|
@woodruffw You want me to delete the token after you test out the workflow or now? |
Now is fine! I've already deactivated it on the PyPI side. |
|
Deleted! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've configured the corresponding publisher on the PyPI side, so this should work out of the box.
Now that we're using trusted publishing, the
PYPI_TOKENsecret can be safely removed. Separately, I'll remove the token on the PyPI side as well.Closes #154.