Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for a more generic observer time, and aligned with v0.2 #179

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Added an option for a more generic observer time, and aligned with v0.2 #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f30224a
Added an option for a more generic observer time, and aligned with v0.2
kommendorkapten Jan 8, 2024
067d477
Renamed a field based on PR feed back and clarified the comment.
kommendorkapten Jan 8, 2024
0b45c38
Update protos/sigstore_verification.proto
kommendorkapten Dec 19, 2023
ace5c19
Updated verification options for tlog integrated time
kommendorkapten Jan 8, 2024
c32e368
Update protos/sigstore_verification.proto
kommendorkapten Jan 8, 2024
f6af7d3
Updated timestamp options:
kommendorkapten Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion gen/jsonschema/schemas/ArtifactVerificationOptions.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,17 @@
"tsaOptions": {
"$ref": "#/definitions/dev.sigstore.verification.v1.ArtifactVerificationOptions.TimestampAuthorityOptions",
"additionalProperties": false,
"description": "Optional options for certificate signed timestamp verification. If none is provided, the default verification options are: Threshold: 1 Disable: false"
"description": "Optional options for certificate signed timestamp verification. If none is provided, the default verification options are: Threshold: 0 Disable: true"
},
"integratedTsOptions": {
"$ref": "#/definitions/dev.sigstore.verification.v1.ArtifactVerificationOptions.TlogIntegratedTimestampOptions",
"additionalProperties": false,
"description": "Optional options for integrated timestamp verification. If none is provided, the default verification options are: Threshold: 0 Disable: true"
},
"observerOptions": {
"$ref": "#/definitions/dev.sigstore.verification.v1.ArtifactVerificationOptions.ObserverTimestampOptions",
"additionalProperties": false,
"description": "Optional options for observed timestamp verification. If none is provided, the default verification options are: Threshold 1 Disable: false"
}
},
"additionalProperties": false,
Expand Down Expand Up @@ -56,6 +66,16 @@
"required": [
"tsa_options"
]
},
{
"required": [
"integrated_ts_options"
]
},
{
"required": [
"observer_options"
]
}
],
"title": "Artifact Verification Options",
Expand Down Expand Up @@ -212,6 +232,21 @@
"type": "object",
"title": "Ctlog Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.ObserverTimestampOptions": {
"properties": {
"threshold": {
"type": "integer",
"description": "The number of external observers of the timestamp. This is a union of RFC3161 signed timestamps, and integrated timestamps from a transparency log, that could include additional timestamp sources in the future."
},
"disable": {
"type": "boolean",
"description": "Disable observer timestamp verification."
}
},
"additionalProperties": false,
"type": "object",
"title": "Observer Timestamp Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.TimestampAuthorityOptions": {
"properties": {
"threshold": {
Expand All @@ -227,6 +262,21 @@
"type": "object",
"title": "Timestamp Authority Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.TlogIntegratedTimestampOptions": {
"properties": {
"threshold": {
"type": "integer",
"description": "The number of integrated timestamps that are expected."
},
"disable": {
"type": "boolean",
"description": "Disable integrated timestamp verification."
}
},
"additionalProperties": false,
"type": "object",
"title": "Tlog Integrated Timestamp Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.TlogOptions": {
"properties": {
"threshold": {
Expand Down
52 changes: 51 additions & 1 deletion gen/jsonschema/schemas/Input.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,17 @@
"tsaOptions": {
"$ref": "#/definitions/dev.sigstore.verification.v1.ArtifactVerificationOptions.TimestampAuthorityOptions",
"additionalProperties": false,
"description": "Optional options for certificate signed timestamp verification. If none is provided, the default verification options are: Threshold: 1 Disable: false"
"description": "Optional options for certificate signed timestamp verification. If none is provided, the default verification options are: Threshold: 0 Disable: true"
},
"integratedTsOptions": {
"$ref": "#/definitions/dev.sigstore.verification.v1.ArtifactVerificationOptions.TlogIntegratedTimestampOptions",
"additionalProperties": false,
"description": "Optional options for integrated timestamp verification. If none is provided, the default verification options are: Threshold: 0 Disable: true"
},
"observerOptions": {
"$ref": "#/definitions/dev.sigstore.verification.v1.ArtifactVerificationOptions.ObserverTimestampOptions",
"additionalProperties": false,
"description": "Optional options for observed timestamp verification. If none is provided, the default verification options are: Threshold 1 Disable: false"
}
},
"additionalProperties": false,
Expand Down Expand Up @@ -692,6 +702,16 @@
"required": [
"tsa_options"
]
},
{
"required": [
"integrated_ts_options"
]
},
{
"required": [
"observer_options"
]
}
],
"title": "Artifact Verification Options",
Expand All @@ -712,6 +732,21 @@
"type": "object",
"title": "Ctlog Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.ObserverTimestampOptions": {
"properties": {
"threshold": {
"type": "integer",
"description": "The number of external observers of the timestamp. This is a union of RFC3161 signed timestamps, and integrated timestamps from a transparency log, that could include additional timestamp sources in the future."
},
"disable": {
"type": "boolean",
"description": "Disable observer timestamp verification."
}
},
"additionalProperties": false,
"type": "object",
"title": "Observer Timestamp Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.TimestampAuthorityOptions": {
"properties": {
"threshold": {
Expand All @@ -727,6 +762,21 @@
"type": "object",
"title": "Timestamp Authority Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.TlogIntegratedTimestampOptions": {
"properties": {
"threshold": {
"type": "integer",
"description": "The number of integrated timestamps that are expected."
},
"disable": {
"type": "boolean",
"description": "Disable integrated timestamp verification."
}
},
"additionalProperties": false,
"type": "object",
"title": "Tlog Integrated Timestamp Options"
},
"dev.sigstore.verification.v1.ArtifactVerificationOptions.TlogOptions": {
"properties": {
"threshold": {
Expand Down
Loading