-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rekor Bundle message #262
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,3 +128,12 @@ message TransparencyLogEntry { | |
// payload from other sources to verify the signature. | ||
bytes canonicalized_body = 7; | ||
} | ||
|
||
// The RekorBundle is the signed material used to produce the Signed Entry | ||
// Timestamp signature. See notes on the InclusionPromise above. | ||
message RekorBundle { | ||
woodruffw marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. naming nit: I don't want to proliferate "bundle" even though it's in cosign, given we want "bundle" to refer to top level protobuf bundle now. Do you have another suggestion of the name? SignedEntryTimestampContents? |
||
bytes body = 1 [(google.api.field_behavior) = REQUIRED]; | ||
int64 integrated_time = 2 [(google.api.field_behavior) = REQUIRED]; | ||
string log_id = 3 [(google.api.field_behavior) = REQUIRED]; | ||
int64 log_index = 4 [(google.api.field_behavior) = REQUIRED]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we confirmed that when marshalled as json as canonicalized, this works as expected? Just want to make sure there's no issues with field naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can run some tests soon. No need to wait on this PR for the new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkatalin I'll plan to include this in a 0.3.2 release with the other change for the checkpoint key ID that just went in.