workflows: Fix valid days check #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually never true:
github.event_name == 'workflow_call'
as the event name in workflow_called workflows is the calling workflows event name.
Use the workflow name to distinguish the cases:
* schedule: name is the test workflow name, use future validity checks
* workflow_dispatch: name is the test workflow name, use future validity checks
* workflow_call from publish.yml: name is calling workflown name, do not use
future validity checks
Using workflow name for this is a bit of a hack and we should consider
adding an input variable for this: that is a bigger change and should be
tested well though.
Signed-off-by: Jussi Kukkonen <[email protected]>
|
Note that the validity periods in the themselves are a bit weird: #1415 I'm on purpose not changing them here as the ongoing signing event will improve things |
kommendorkapten
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually never true:
github.event_name == 'workflow_call'
as the event name in workflow_called workflows is the calling workflows event name.
Use the workflow name to distinguish the cases:
Using workflow name for this is a bit of a hack and we should consider adding an input variable for this: that is a bigger change and should be tested well though.
See #1416.