tests: Require metadata to be valid for 5 days #1449
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now signing timestamp 6 days before expiry (meaning every day). This means we can now require metadata to be valid for 5 days in the tests. The change gives us more time to react to online signing issues. Change has been tested in staging: sigstore/root-signing-staging#222 Signed-off-by: Jussi Kukkonen <[email protected]>
cpanato
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now signing timestamp 6 days before expiry (meaning every day). This means we can now require metadata to be valid for 5 days in the tests.
The change gives us more time to react to online signing issues.
Change has been tested in staging:
sigstore/root-signing-staging#222
Fixes #1415