Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tuf dependency #1017

Merged
merged 2 commits into from
May 14, 2024
Merged

Upgrade tuf dependency #1017

merged 2 commits into from
May 14, 2024

Conversation

jku
Copy link
Member

@jku jku commented May 14, 2024

The ngclient API that we use is fully backwards-compatible but I want to do two small changes so am bumping the required version:

  • Don't poke into fetcher internals: the timeout is now the 30 seconds we wanted
  • set user-agent through UpdaterConfig: this will end up as "sigstore-python/3.0.0rc2 tuf/5.0.0 python-requests/2.31.0" (a bit verbose perhaps but all of that is useful)

The ngclient API that we use is actually backwards-compatible
but I want to do two changes so bumping the required version:
* Don't poke into fetcher internals: the timeout is now
  the 30 seconds we wanted
* set user-agent through UpdaterConfig: this will end up as
  "sigstore-python/3.0.0rc2 tuf/5.0.0 python-requests/2.31.0"

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku requested a review from woodruffw May 14, 2024 11:56
@jku jku marked this pull request as draft May 14, 2024 11:58
_get_fetcher() no longer exists: mock python-tuf constructor instead

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku marked this pull request as ready for review May 14, 2024 12:29
@woodruffw woodruffw merged commit 09da22b into sigstore:main May 14, 2024
23 checks passed
@woodruffw
Copy link
Member

Thanks @jku!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants