Add minimum version to interrogate dependency #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
remove-interrogate-hack
branch
from
c7e2c79
to
7fb2d1f
Compare
Signed-off-by: Facundo Tuesca <[email protected]>
facutuesca
force-pushed
the
remove-interrogate-hack
branch
from
7fb2d1f
to
3bcf550
Compare
|
/gcbrun |
woodruffw
approved these changes
Sep 5, 2024
|
Thanks @facutuesca! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
setuptoolswas included in thelintdependencies due to a bug ininterrogate. Since that bug was fixed, we removesetuptoolsand add a constraint to theinterrogateversion to ensure we use a version with the fix.cc @woodruffw