Attestation CLI command improvements #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Facundo Tuesca <[email protected]>
woodruffw
reviewed
Sep 13, 2024
facutuesca
force-pushed
the
attest-fixes
branch
from
a3dd2d4
to
764d401
Compare
woodruffw
reviewed
Sep 13, 2024
woodruffw
reviewed
Sep 13, 2024
facutuesca
force-pushed
the
attest-fixes
branch
from
764d401
to
2b0584b
Compare
Signed-off-by: Facundo Tuesca <[email protected]>
facutuesca
force-pushed
the
attest-fixes
branch
from
2b0584b
to
fa0bae7
Compare
Signed-off-by: Facundo Tuesca <[email protected]>
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1115 (comment) and #1115 (comment).
This PR:
sigstore attestto sign over the predicate file's contents, rather than our Pydantic model JSON dump. See the comments in the code for the rationale.enum.Enumfor the predicate typescc @woodruffw