Add support for verifying digests to CLI verify commands #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
verify-digest
branch
from
50d20c7
to
ea1560e
Compare
woodruffw
reviewed
Sep 16, 2024
Comment on lines
+59
to
+63
| def __str__(self) -> str: | ||
| """ | ||
| Returns a str representation of this `Hashed`. | ||
| """ | ||
| return f"{self.algorithm.name}:{self.digest.hex()}" |
There was a problem hiding this comment.
Small unit test for this, please 🙂
There was a problem hiding this comment.
Done, see last commit
woodruffw
previously approved these changes
Sep 16, 2024
There was a problem hiding this comment.
LGTM, nice work @facutuesca! One small request for a unit test.
|
/gcbrun |
di
reviewed
Sep 16, 2024
di
reviewed
Sep 16, 2024
Signed-off-by: Facundo Tuesca <[email protected]>
facutuesca
force-pushed
the
verify-digest
branch
from
ea1560e
to
6f50e6a
Compare
|
/gcbrun |
Signed-off-by: Facundo Tuesca <[email protected]>
|
/gcbrun |
|
/gcbrun |
woodruffw
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the
sigstore verifyCLI command so that it accepts digests as inputs (in addition to files).Concretely:
This is useful in scenarios where the user doesn't want/need to download the artifact, but has access to its digest.
Related to sigstore/sigstore-conformance#157
Release Note
sigstore verifycommand now supports verifying digests. This meansthat the user can now pass a digest like
sha256:aaaa....instead of thepath to an artifact, and
sigstore-pythonwill verify it as if it was theartifact with that digest.
Documentation
Example added to the README
cc @woodruffw