Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models for TimestampVerificationData #1186

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

DarkaMaul
Copy link
Contributor

As explained in #1182 , this is the first PR to complete the support of timestamp verification in sigstore-python.

/cc @woodruffw @facutuesca

pyproject.toml Outdated Show resolved Hide resolved
@woodruffw woodruffw added component:verification Core verification functionality component:api Public APIs labels Oct 24, 2024
sigstore/models.py Outdated Show resolved Hide resolved
sigstore/models.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
DarkaMaul and others added 3 commits November 6, 2024 16:01
Co-authored-by: Facundo Tuesca <[email protected]>
Signed-off-by: dm <[email protected]>
Signed-off-by: Alexis <[email protected]>
@woodruffw
Copy link
Member

/gcbrun

woodruffw
woodruffw previously approved these changes Nov 6, 2024
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise LGTM, thanks @DarkaMaul!

Co-authored-by: William Woodruff <[email protected]>
Signed-off-by: dm <[email protected]>
Signed-off-by: Alexis <[email protected]>
@woodruffw
Copy link
Member

/gcbrun

@woodruffw woodruffw enabled auto-merge (squash) November 6, 2024 18:09
@woodruffw woodruffw merged commit 0a069f7 into sigstore:main Nov 6, 2024
23 checks passed
@DarkaMaul DarkaMaul deleted the dm/ts-models branch November 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Public APIs component:verification Core verification functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants