-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models for TimestampVerificationData #1186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis <[email protected]>
Signed-off-by: Alexis <[email protected]>
DarkaMaul
force-pushed
the
dm/ts-models
branch
from
October 24, 2024 08:20
9245026
to
3bc3356
Compare
woodruffw
reviewed
Oct 24, 2024
woodruffw
added
component:verification
Core verification functionality
component:api
Public APIs
labels
Oct 24, 2024
Signed-off-by: Alexis <[email protected]>
Signed-off-by: Alexis <[email protected]>
facutuesca
reviewed
Nov 6, 2024
facutuesca
reviewed
Nov 6, 2024
Co-authored-by: Facundo Tuesca <[email protected]> Signed-off-by: dm <[email protected]>
Signed-off-by: Alexis <[email protected]>
Signed-off-by: Alexis <[email protected]>
/gcbrun |
woodruffw
reviewed
Nov 6, 2024
woodruffw
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick, otherwise LGTM, thanks @DarkaMaul!
Co-authored-by: William Woodruff <[email protected]> Signed-off-by: dm <[email protected]>
Signed-off-by: Alexis <[email protected]>
/gcbrun |
woodruffw
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #1182 , this is the first PR to complete the support of timestamp verification in
sigstore-python
./cc @woodruffw @facutuesca