-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds cert-utility templates and documentation. #889
base: main
Are you sure you want to change the base?
Conversation
045fbec
to
cb8fc28
Compare
970c9cd
to
cfdf4ea
Compare
159ac3f
to
de035f7
Compare
i think this is ready for 👀 now. just a couple of notes.
i think that about covers it, i have some basic readme/documentation above as well. |
de035f7
to
fcee964
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 52.85% 47.47% -5.38%
==========================================
Files 20 58 +38
Lines 1209 4303 +3094
==========================================
+ Hits 639 2043 +1404
- Misses 509 2076 +1567
- Partials 61 184 +123 ☔ View full report in Codecov by Sentry. |
dfa131c
to
02345bb
Compare
c0c269c
to
5d442d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the comment I just left on the other PR, I wonder if we can reduce duplication between these two. The only difference between the two is 1) the templates, and 2) that the TSA needs a leaf certificate and Fulcio doesn't.
In the Fulcio codebase, could we have certificate_maker have leaf be optional? Then in this repo, just have a readme pointing to the fulcio codebase and the templates for the TSA?
yeah, that's what i was thinking / i think that totally works.
heh, it's the end of the day here and i didn't connect the dots. |
Roots are always required, intermediates are optional, and leafs are optional (for a CA vs TSA). |
perfect / should i create a new issue in fulcio for this work or ? |
Feel free to just create a PR in Fulcio making the leaf optional, then update this PR to be just the templates plus README. Thanks! |
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
…escriptive. Signed-off-by: ianhundere <[email protected]>
… consistent w/ flags. Signed-off-by: ianhundere <[email protected]>
…e flag to gcp-credentials-file. Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
…son error. Signed-off-by: ianhundere <[email protected]>
…per, and other PR fb. Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
…vements. Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
5d442d2
to
42f065c
Compare
Signed-off-by: ianhundere <[email protected]>
7a67fae
to
2282744
Compare
this is ready for 👀 |
closes #886, closes sigstore/fulcio#1930
Summary
currently, there is no standard method for creating cert chains for fulcio or tsa. the community has used an assortment of open source scripts/tools, but i thought it would be nice to have a small cloud agnostic go app to create/sign (via awskms, gcpkms, or azurekms) certificates. the smallstep crypto library is fairly comprehensive in its kms/cert capabilities.
@haydentherapper / @bobcallaway gave the go ahead in proceeding w/ this work.
Release Note
Documentation
added docs to
./docs
folder and updatedREADME.md
to point to docs.